fix: disable OTel and reduce concurrency for CI reliability#218
fix: disable OTel and reduce concurrency for CI reliability#218slayerjain merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to make proxy-stress-test runs more deterministic in CI by disabling OpenTelemetry exporting and reducing background activity and concurrency.
Changes:
- Reduce connection concurrency and batch size from 42 to 10 to stabilize CI runs.
- Disable OTel exporting to avoid noisy/irrelevant errors during replay.
- Disable background noise connections to improve determinism.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
proxy-stress-test/docker-compose.yml
Outdated
| # High concurrency to stress-test cert generation and error channel. | ||
| # 42 matches the production traffic pattern from Agoda travel-card-api. |
There was a problem hiding this comment.
The comment still states that 42 matches the production traffic pattern, but CONCURRENT_CONNS/BATCH_SIZE are now set to 10. Please update or reword these comments so the documented rationale matches the current values.
| # High concurrency to stress-test cert generation and error channel. | |
| # 42 matches the production traffic pattern from Agoda travel-card-api. | |
| # Moderate concurrency to stress-test cert generation and error channel. | |
| # 10 concurrent connections per batch matches the current replay setup. |
proxy-stress-test/docker-compose.yml
Outdated
| # OTel enabled with no collector — generates mock-not-found errors | ||
| # that stress the error channel during replay. |
There was a problem hiding this comment.
These comments say OTel is enabled with no collector, but OTEL_ENABLED is now set to "false". Update the comments to reflect that OTel exports are intentionally disabled for deterministic CI replay (or remove the now-misleading explanation).
| # OTel enabled with no collector — generates mock-not-found errors | |
| # that stress the error channel during replay. | |
| # OTel exports are intentionally disabled to keep CI replay deterministic. | |
| # Exporter settings remain here for easy local re-enablement if needed. |
proxy-stress-test/docker-compose.yml
Outdated
| OTEL_ENABLED: "false" | ||
| OTEL_EXPORTER_OTLP_ENDPOINT: "localhost:4318" | ||
| OTEL_EXPORT_INTERVAL: "500ms" | ||
| # Background noise connections stress error channel between tests. |
There was a problem hiding this comment.
The comment implies background noise connections are used to stress the error channel, but BG_NOISE_CONNS is now "0". Update the comment to reflect that background noise is intentionally disabled for CI determinism.
| # Background noise connections stress error channel between tests. | |
| # Background noise connections are intentionally disabled for CI | |
| # determinism between test runs. |
slayerjain
force-pushed
the
fix/proxy-stress-ci-reliability
branch
from
7f544b5 to
3907d1d
Compare
OTel exports to a non-existent collector cause mock-not-found errors during replay which fail the test. Background noise connections add unpredictable outgoing traffic that doesn't replay deterministically. Reduced CONCURRENT_CONNS from 42 to 10 for faster CI runs while still exercising the cert caching and PG reassembly code paths. Signed-off-by: Shubham Jain <shubham@keploy.io> Signed-off-by: slayerjain <shubhamkjain@outlook.com>
slayerjain
force-pushed
the
fix/proxy-stress-ci-reliability
branch
from
3907d1d to
c27e937
Compare
Disables OTel exports and background noise in proxy-stress-test for
deterministic CI replay. Reduces concurrency from 42 to 10 for speed
while still exercising cert caching and PG reassembly.