Conversation
|
@crowsonkb I am not convinced that this is actually necessary. The implementation of the original authors does not do this. In fact, it seems to me as if they explicitly changed their implementation to undo the changes in your PR. Notice also that we do use the |
|
Hello, I'm a bot! I can make mistakes, notify gabrieldemarmiesse if I made one. I see that you modified the following file:
The owner of those file is @MFreidank @MFreidank could you please take a look at it whenever |
|
@MFreidank please ignore the bot's message, my bot is up and running and it was just triggered for this PR. |
|
@gabrieldemarmiesse |
The formula for computing Padam's unbiased learning rate
lr_tis currently only valid whenpartial= 1/2, because it was copied unchanged from Adam/AMSGrad wherepartialis effectively always 1/2. This PR corrects it so it is valid for any value ofpartial.