Skip to content

Fix: Replace manual unzip shell command with Python zipfile #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaytiwarihub wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix: Replace manual unzip shell command with Python zipfile #2229

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba830e5
Fix: Replace manual unzip shell command with Python zipfile
jaytiwarihub Jan 3, 2026
e09e613
Fix: Reorder imports to satisfy linter
jaytiwarihub Jan 3, 2026
85896c5
Refactor: Use pathlib for file handling
jaytiwarihub Jan 5, 2026
2099d73
Trigger CLA check
jaytiwarihub Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions examples/audio/speaker_recognition_using_cnn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,22 +45,33 @@
os.environ["KERAS_BACKEND"] = "tensorflow"

import shutil
import zipfile
import numpy as np

import tensorflow as tf
import keras

from pathlib import Path
from IPython.display import display, Audio

# Get the data from https://www.kaggle.com/kongaevans/speaker-recognition-dataset/
# and save it to ./speaker-recognition-dataset.zip
# then unzip it to ./16000_pcm_speeches
"""shell
kaggle datasets download -d kongaevans/speaker-recognition-dataset
unzip -qq speaker-recognition-dataset.zip
"""

DATASET_ROOT = "16000_pcm_speeches"
ZIP_FILE = "speaker-recognition-dataset.zip"

DATASET_ROOT = Path("16000_pcm_speeches")
ZIP_FILE = Path("speaker-recognition-dataset.zip")

# Check if the dataset is already extracted
if not DATASET_ROOT.exists():
# Check if the zip file is present
if ZIP_FILE.exists():
print(f"Extracting {ZIP_FILE}...")
with zipfile.ZipFile(ZIP_FILE, "r") as zip_ref:
zip_ref.extractall(DATASET_ROOT)
print("Extraction complete.")
else:
# If neither exists, guide the user
print(f"Dataset not found. Please download it from:")
print("https://www.kaggle.com/kongaevans/speaker-recognition-dataset")
print(f"Save it as '{ZIP_FILE}' in this directory and run again.")
exit()
DATASET_ROOT = "16000_pcm_speeches"
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The DATASET_ROOT variable is already defined on line 56. This re-definition is redundant and can be safely removed.


# The folders in which we will put the audio samples and the noise samples
Expand Down