Skip to content

Updating TF to Keras migration guide#2231

Open
rcrowe-google wants to merge 2 commits intokeras-team:masterfrom
rcrowe-google:master
Open

Updating TF to Keras migration guide#2231
rcrowe-google wants to merge 2 commits intokeras-team:masterfrom
rcrowe-google:master

Conversation

@rcrowe-google
Copy link
Copy Markdown

I've only updated the notebook, so hopefully the .md and .py files will be updated by the CI.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @rcrowe-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the Keras 2 to Keras 3 migration guide, specifically the Jupyter notebook version. The changes aim to provide a more robust and user-friendly experience by clarifying instructions, updating code examples with better error handling, and refining the overall content to reflect current best practices for migrating TensorFlow Keras code to the multi-backend Keras 3 framework.

Highlights

  • Guide Content Refinement: The migration guide's title has been updated to explicitly mention 'TensorFlow Keras 2 code (tf.keras)', and the content has been revised for clarity and accuracy, including updated author information and last modified date.
  • Code Example Robustness: Numerous code examples throughout the notebook have been enhanced with try/except blocks to prevent CI failures and provide more informative error handling, particularly for jit_compile issues, SavedModel operations, TF Autograph, TF variable tracking, and None entries in call() arguments.
  • Installation and Setup: The installation instruction was updated from keras-nightly to keras, and version printing for Keras and TensorFlow was added to the setup section for better context.
  • Removed Section: The section discussing issues with 'Using deeply nested inputs in Functional Models' has been removed from the guide.
  • State-Building Fixes: The guidance for state-building issues has been improved, including an updated error message example and a more complete fix that demonstrates implementing a build() method for custom layers.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a significant update to the Keras 2 to Keras 3 migration guide. The changes include updating package names, adding runnable code examples for reproducing errors and demonstrating fixes, and clarifying explanations. These are excellent improvements that will make the guide more practical and easier to follow. However, I've noticed that two important sections detailing breaking changes related to handling nested inputs in Functional Models and the behavior of evaluate() with multi-output models have been removed. I've recommended re-adding them to ensure the guide remains comprehensive for users migrating from Keras 2. Additionally, I've suggested some cleanups to the operator mapping tables to remove redundancies and correct a mapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants