oauth: allow passing additional credential data to providers #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be needed to pass some additional data (key ID + team ID) to the apple provider. The signing key could be included in the additional map as well I suppose but since that can be used by all providers I think it makes sense to include as a top-level detail. |
AlexCuse
force-pushed
the
additional-credential-data
branch
from
924fd66 to
0a2317b
Compare
|
@cainlevy any concerns about this? I have the Apple implementation near ready to test built on top of this. Feeling like it will be time to do configuration files next 😅 |
|
Yea might merge with the Apple stuff to keep blame where it belongs for posterity 😅 |
|
Included in #243 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.