-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix desync charactorvisitors and Caxton compatibility #14
Fix desync charactorvisitors and Caxton compatibility #14
Conversation
…ith extended style rather then multiple characters
I'm out of town for the weekend but I'm planning to take a closer look at this marvel on Tuesday 😁 |
…modified and brought all else to parity with the previous version
…mly be prioritised (visible starting in version 1.21.4)
f34ad52
to
6cc2e84
Compare
I don't know why this didn't cause infinite recursion 🤔
86da988
to
8e71e47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I marked getWidthMutex
as volatile since I can't imagine any kind of "mutex" that wouldn't be. I'm just not sure what getWidthMutex
and isSeparatingDrawCall
are and if maybe they should both be marked volatile.
src/main/java/com/kevinsundqvistnorlen/rubi/mixin/client/MixinTextHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/kevinsundqvistnorlen/rubi/mixin/client/MixinTextRenderer.java
Outdated
Show resolved
Hide resolved
I must thank you for this. Using a single character per ruby and storing the details in the style is a really elegant solution to the line wrapping and overflow issues. If you feel this PR is ready, I'm happy to merge it.
I'm not entirely sure what this point is referring to. Has this been resolved? |
It is about the chat, where you can autocomplete names or parts of commands and ghosts of the suggestions is slightly shifted when not using Caxton. Unfortunately, it is still not fixed and have yet to find the source of the problem. Edit: I just found the problem is more generally characters to the right of cursor are rendered to far left. |
… drawn with shadow
@keve1227, I believe it is now ready for merging. |
(Due to me breaking the width receiver mixin with 1cec407)
Now it's ready. |
Update to MC 1.21.4 based on PR #14
Fix desync charactervisitors and Caxton compatibility
Fix desync charactervisitors and Caxton compatibility
Fix desync charactervisitors and Caxton compatibility
Fix desync charactervisitors and Caxton compatibility
Hey, I was abble to try it it worked ! Unfortunatly most of the mod are still stucked in 1.21.1 so i cannot play with the 1.21.3 mod. Is there a way to lunch this mod in this version ? or do you think that you can also correct the bug in 1.21.1. Thank you in advance ! |
I have started work on this and, except for a small problem which won't get in the way, it seems to work. This work can be seen in #18. You can also download the artifact from there. |
This pull request aims to fix #12 (#16) and improve compatibility.
The fix of #12 has currently been achieved.
Compatibility (#1) has not been tested. Caxton is now compatible as of 5f80a30 (fix keve1227/furigana#3).
I have changed the architecture from "$^text(ruby)" converting to "\ue9c0text\ue9c1ruby\ue9c2" now replacing "$^text(ruby)" with a single character (\uFFFC) and then embedding the text and ruby in the net.minecraft.text.Style class.
As this is a major rewrite, there is currently still some differences in rendering which need to be fixed: