[WIP] Acts Geo Gen3 DD4hep conversion#36
Conversation
bfc300c to
bccc01e
Compare
2f654fa to
18b5f4f
Compare
e1c026b to
c0622b8
Compare
|
|
||
| /// A simple struct to hold configuration to build a tracker that is nested | ||
| /// such that a simple stacking in z does not work. | ||
| struct NestedInnerTrackerSpec { |
There was a problem hiding this comment.
Do you think something like this should exist at the library level?
There was a problem hiding this comment.
I am not entirely sure. I don't see a way to make this general enough to be useful without inventing another semi DSL just for this purpose. This specific thing works for our case, where there is one (or a few) endcap layers that protrude into the cylinder formed by the outermost barrel layer(s). However, we currently only have this nesting once (in a subdetector). As soon as we have, e.g. two different levels of protrusion it no longer works. The way out would be to simply call this thing twice with different configurations, but then one would have to potentially add more config, e.g. to allow for "empty" layers.
Given that it's fairly straight forward to build this on our end on top of the proposed API, I would keep it in "userland" and see if it's common enough there to merit upstreaming later.
5933a8a to
8197a6e
Compare
|
With the changes in paulgessinger/acts#33 we now also support planar geometries, like LUXE |
Most of the Acts downstream assumes a shared_ptr, so we might as well return one from here
Make the ActsGeoSvc implementation return a constant magnetic field along for now.
Either absorbed by other services or not part of the context of this PR
8197a6e to
17edab4
Compare
BEGINRELEASENOTES
exactly as it appears between the two bold lines
ENDRELEASENOTES
This is a work in progress with the main purpose of being able to share ongoing efforts. So far the efforts focus on getting (parts) of the
MAIA_v0geometry conversion tested and evaluated against upstream work happening at currently living on https://github.com/paulgessinger/acts/tree/feat/dd4hep-gen3For the
MAIA_v0geometry, this needs key4hep/k4geo#549