Support building on modern MSYS2 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Source/NSSavePanel.m: Fix return type of sorting function.
…nerating COFF files. See https://reviews.llvm.org/D75989 and https://maskray.me/blog/2021-04-25-weak-symbol This would lead to linker errors like this: ``` C:/tools/msys64/ucrt64/bin/ld: obj/libgnustep-gui.obj/NSBitmapImageRep+GIF.m.o:NSBitmapImageRep+G:(.rdata+0x418): multiple definition of `.weak.__objc_class_ref_NSString.default..objc_sel_namealloc'; obj/libgnustep-gui.obj/NSAttributedString.m.o:NSAttributedString:(.rdata+0xc38): first defined here C:/tools/msys64/ucrt64/bin/ld: obj/libgnustep-gui.obj/NSBitmapImageRep+GIF.m.o:NSBitmapImageRep+G:(.rdata+0x508): multiple definition of `.weak.__objc_class_ref_NSNumber.default..objc_sel_namealloc'; obj/libgnustep-gui.obj/NSAttributedString.m.o:NSAttributedString:(.rdata+0xc20): first defined here C:/tools/msys64/ucrt64/bin/ld: obj/libgnustep-gui.obj/NSBitmapImageRep+ICNS.m.o:NSBitmapImageRep+I:(.rdata+0x400): multiple definition of `.weak.__objc_class_ref_NSData.default..objc_sel_namealloc'; obj/libgnustep-gui.obj/NSBitmapImageRep+GIF.m.o:NSBitmapImageRep+G:(.rdata+0x4f0): first defined here ```
…scussed in the documentation
…SIArrayItem and GSIArray. This issue wasn't caught by CI since gui was not recompiled after base was altered.
This class is shared between the StandardPicker bundle and the WheelPicker bundles. Exposing a class with the same name in two separate bundles results in undefined behavior. Move this class to a shared module (libs-gui in this case) to resolve that.
johnathan-becker
merged commit b7074e5
into
keysight-eggplant:gnustep_testplant_branch
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: