Add IntercoolerJS views to work with templates and requests efficiently #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Django 1.10+ is using MIDDLEWARE instead of MIDDLEWARE_CLASSES, another variable need to be added.
|
I have updated test matrix in my master branch, also added necessary tests and refactored as in ic_views branch. Please help to review the changes. Thank you in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using IntercoolerJS with Django, there are scenarios that we split
small parts of a template page into several template files. Instead, there is
need is to extract needed part from single template file for multiple
IntercoolerJS requests.
Another need is to group tasks to render those parts and to call rendering
tasks accoding to IntercoolerJS' attributes: request's method, trigger id,
and target id.
I proposed the solution as in this pull request. I added two sections in
demo_project.html but I not yet develop tests.
Please help to review and let me know if you want to include the proposal in
your repository. Then I will develop tests and create another pull request for
you to review. Thank you in advance for your time to consider this.