*: Remove cloudbuilder from the repository part 1 #10433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timflannagan
force-pushed
the
chore/purge-cloudbuilder
branch
from
9e58265 to
9a5bd55
Compare
timflannagan
commented
Jan 10, 2025
timflannagan
changed the title
|
There's still a couple more cloudbuild references remaining in the repository, but they're largely around the release process that cloudbuild was previously supporting. I was planning on tackling that in a part 2 once we iron out that process going forward. |
This commit is part 1 for purging cloudbuilder from the repository. Follow-up commit(s) and PRs will purge the test suites, consul & vault, etc. dependencies from source control. Signed-off-by: timflannagan <[email protected]>
The test/consulvaulte2e suite was one of the test suites that cloudbuilder was configured to run on PRs. See kgateway-dev#10432 for the issue that tracks whether we should migrate the other suite being run (e.g. run-e2e-tests) and whether it's still relevant for this project. Signed-off-by: timflannagan <[email protected]>
timflannagan
force-pushed
the
chore/purge-cloudbuilder
branch
from
9a5bd55 to
46c3bf8
Compare
nfuden
approved these changes
Jan 14, 2025
jenshu
approved these changes
Jan 14, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 14, 2025
Signed-off-by: timflannagan <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the first step towards purging the buildbot/cloudbuilder dependencies from the repository.
For CI: there are currently two suites that are run in the solo-io/gloo fork that buildbot is responsible for executing. The run-hashicorp-e2e Makefile target isn't relevant to this project's goals, so we remove that target & it's corresponding suite in these set of changes. I created #10432 to track whether it's worth migrating over the other test suite.
For the release process: we're in the process of overhauling / rethinking how we release our container images & helm charts, so we can remove this cloudbot configuration entirely. See #10441 for the issue tracking this stream of work.
I took an initial stab at deleting the test/consulvaulte2e suite directory & the Makefile target. Note: I think we'll need follow-up cleanup changes to rip out the consul & vault related code over time.
Checklist: