*: Migrate container registry from quay.io to ghcr.io #10484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a follow-up to kgateway-dev#10443 and kgateway-dev#10470 and migrates away from the quay.io/solo-io container image registry in favor of the ghcr.io repository in the project. Additional work around renaming the gloo component, binaries, etc. will be handled once we're closing the finish line with the Signed-off-by: timflannagan <[email protected]>
timflannagan
commented
Jan 21, 2025
There was a problem hiding this comment.
IMO this test case can be removed. I held off for now until the release pipeline is closer to the finish line.
jenshu
reviewed
Jan 21, 2025
| @@ -9,8 +9,7 @@ on: | |||
| - main | |||
|
|
|||
| env: | |||
| # IMAGE_REGISTRY: ghcr.io/${{ github.repository_owner }} | |||
| IMAGE_REGISTRY: quay.io/solo-io | |||
| IMAGE_REGISTRY: ghcr.io/${{ github.repository_owner }} | |||
There was a problem hiding this comment.
does repository_owner == kgateway?
There was a problem hiding this comment.
I actually like it this way. Makes forks easier to maintain
There was a problem hiding this comment.
Yep! We could hardcode the image registry here, but this approach allows us to easily test the workflow in forks.
There was a problem hiding this comment.
oh didn't mean we should hardcode; i was just confirming if the value of repository_owner is indeed kgateway, as opposed to kgateway-dev (org name). before, it seemed to be the org name
jenshu
approved these changes
Jan 21, 2025
4 tasks
lgadban
added a commit
that referenced
this pull request
Jan 23, 2025
commit b3fa763 Author: Tim Flannagan <[email protected]> Date: Tue Jan 21 16:17:55 2025 -0500 *: Migrate container registry from quay.io to ghcr.io (#10484) Signed-off-by: timflannagan <[email protected]> commit b46e5e2 Author: Jenny Shu <[email protected]> Date: Tue Jan 21 12:47:25 2025 -0500 Admin server - part 2 (#10482) commit cb5a24f Author: Nathan Fudenberg <[email protected]> Date: Tue Jan 21 08:42:16 2025 -0500 naming clean up k8sgateway -> kgateway (#10477) Co-authored-by: Jenny Shu <[email protected]> commit e649e3b Author: Nathan Fudenberg <[email protected]> Date: Mon Jan 20 17:01:08 2025 -0500 Fix/scrubdevel (#10475) Co-authored-by: Jenny Shu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit is a follow-up to #10443 and #10470 and migrates away from the quay.io/solo-io container image registry in favor of the ghcr.io repository in the project.
Additional work around renaming the gloo component, binaries, etc. will be handled once we're closing the finish line with the #10444 cleanup work.
Introducing automation to replace the quay container image expiration label is being tracked in the #10441 epic.
Checklist: