e2e profiles #10634
e2e profiles #10634
Conversation
Signed-off-by: Jenny Shu <[email protected]>
Signed-off-by: Jenny Shu <[email protected]>
Signed-off-by: Jenny Shu <[email protected]>
| # This file defines the common recommendations for a user who wants to run Gloo Gateway. | ||
| # As we call out in the [profiles README](./profiles/README.md), these should be reviewed and tested | ||
| # before being adopted. | ||
| # This file defines the common recommendations for a user who wants to run kgateway. |
There was a problem hiding this comment.
this file is currently mostly commented out; need to figure out what the new helm values are. the current chart might not support all of them yet. filed #10635 to track
There was a problem hiding this comment.
in general think having a set of "production recommendation" is generally overkill for the current state of the project/helm chart, but keeping this file around mostly commented out makes sense to me in the short term
There was a problem hiding this comment.
+1 on profiles being a bit premature right now.
There was a problem hiding this comment.
yeah i don't know if there's much to add to this file for now, but eventually we might have some recommended values documented (like we did for edge in production) and probably want to test them here
Signed-off-by: Jenny Shu <[email protected]>
There was a problem hiding this comment.
fine leaving as-is for now but pretty much all values in here other than global are no longer relevant right?
| # This file defines the common recommendations for a user who wants to run Gloo Gateway. | ||
| # As we call out in the [profiles README](./profiles/README.md), these should be reviewed and tested | ||
| # before being adopted. | ||
| # This file defines the common recommendations for a user who wants to run kgateway. |
There was a problem hiding this comment.
in general think having a set of "production recommendation" is generally overkill for the current state of the project/helm chart, but keeping this file around mostly commented out makes sense to me in the short term
Previously, our e2e tests applied 3 levels of helm values:
The latter 2 files would be specified by each test as part of the kgateway.Context, and then when installing the chart, the test helper would apply the production recommendations manifest, along with the profile manifest and the test-specific manifest.
We no longer need the profile manifest (since only kube gateway is supported), so removed the references to those profiles. In addition, to make the use of the "production recommendations" manifest more explicit, repurposed the
ProfileValuesManifestFilein the existing tests to point to the production recommendations manifest (instead of the test helper making an assumption that it should always be used).