(chore): use native go instead of curl pod in non agentgateway tests#13453
Open
1Shubham7 wants to merge 7 commits intokgateway-dev:mainfrom
Open
(chore): use native go instead of curl pod in non agentgateway tests#134531Shubham7 wants to merge 7 commits intokgateway-dev:mainfrom
1Shubham7 wants to merge 7 commits intokgateway-dev:mainfrom
Conversation
…n agentgateway extauth Signed-off-by: shubham singh mahar <smahar@obmondo.com>
8182687 to
a62204f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ExtAuth e2e test suite to stop relying on a dedicated curl pod and instead use the shared Go-based gateway client used by agentgateway tests.
Changes:
- Remove the curl pod manifest and its associated resources from the ExtAuth e2e test setup.
- Initialize
common.BaseGatewayin the ExtAuth suite usingSetupBaseGateway, and useBaseGateway.Sendfor HTTP requests instead ofAssertEventualCurlResponsewith a curl pod. - Update readiness checks to wait on the super-gateway and ext-authz pods directly, rather than the curl pod.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
npolshakova
requested changes
Feb 2, 2026
Contributor
npolshakova
left a comment
There was a problem hiding this comment.
Couple notes:
- The changes should be at the suite level not at the per-feature test level:
- Please update the PR description to be correctly formatted based on the template (description, release note should be NONE for non-user changes, etc.)
Contributor
Author
|
got it @npolshakova ! since I just had changed one test, it would mess up other tests so that was a temp measure : ) also, what did you mean by non-user changes? |
Contributor
|
The PR description needs to follow the PR template. See the contributing guide and design doc for changelog management for more info:
Use |
…s to native go Signed-off-by: shubham singh mahar <smahar@obmondo.com>
24005b7 to
34ccce1
Compare
added 5 commits
February 4, 2026 10:55
…o native go Signed-off-by: shubham singh mahar <smahar@obmondo.com>
…to native go code
…roDowntime, Metrics tests to native go code
… and transformation tests to native go code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrating all the non agentgateway tests from curl pods to native go http client
Description
part of #13053
Change Type
/kind fix
Changelog
Additional Notes
session_persistence- It needs the raw response to extract cookies/headers and then later assert those.