Skip to content

(chore): use native go instead of curl pod in non agentgateway tests#13453

Open
1Shubham7 wants to merge 7 commits intokgateway-dev:mainfrom
1Shubham7:faster-tests
Open

(chore): use native go instead of curl pod in non agentgateway tests#13453
1Shubham7 wants to merge 7 commits intokgateway-dev:mainfrom
1Shubham7:faster-tests

Conversation

@1Shubham7
Copy link
Contributor

@1Shubham7 1Shubham7 commented Feb 2, 2026

Migrating all the non agentgateway tests from curl pods to native go http client

Description

part of #13053

--- PASS: TestKgateway (56.26s)
    --- PASS: TestKgateway/ExtAuth (45.10s)
        --- PASS: TestKgateway/ExtAuth/TestExtAuthPolicy (1.28s)
            --- PASS: TestKgateway/ExtAuth/TestExtAuthPolicy/request_allowed_with_allow_header (0.01s)
            --- PASS: TestKgateway/ExtAuth/TestExtAuthPolicy/request_denied_without_allow_header (0.00s)
            --- PASS: TestKgateway/ExtAuth/TestExtAuthPolicy/request_denied_with_deny_header (0.00s)
            --- PASS: TestKgateway/ExtAuth/TestExtAuthPolicy/request_allowed_on_insecure_route (0.00s)
        --- PASS: TestKgateway/ExtAuth/TestRouteTargetedExtAuthPolicy (1.26s)
            --- PASS: TestKgateway/ExtAuth/TestRouteTargetedExtAuthPolicy/request_allowed_by_default (0.00s)
            --- PASS: TestKgateway/ExtAuth/TestRouteTargetedExtAuthPolicy/request_allowed_on_insecure_route (0.00s)
            --- PASS: TestKgateway/ExtAuth/TestRouteTargetedExtAuthPolicy/request_allowed_with_allow_header_on_secured_route (0.00s)
            --- PASS: TestKgateway/ExtAuth/TestRouteTargetedExtAuthPolicy/request_denied_without_header_on_secured_route (0.00s)

Change Type

/kind fix

Changelog

NONE

Additional Notes

  • Not migrating session_persistence - It needs the raw response to extract cookies/headers and then later assert those.

Copilot AI review requested due to automatic review settings February 2, 2026 07:33
@gateway-bot gateway-bot added kind/fix Categorizes issue or PR as related to a bug. release-note labels Feb 2, 2026
…n agentgateway extauth

Signed-off-by: shubham singh mahar <smahar@obmondo.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ExtAuth e2e test suite to stop relying on a dedicated curl pod and instead use the shared Go-based gateway client used by agentgateway tests.

Changes:

  • Remove the curl pod manifest and its associated resources from the ExtAuth e2e test setup.
  • Initialize common.BaseGateway in the ExtAuth suite using SetupBaseGateway, and use BaseGateway.Send for HTTP requests instead of AssertEventualCurlResponse with a curl pod.
  • Update readiness checks to wait on the super-gateway and ext-authz pods directly, rather than the curl pod.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@npolshakova npolshakova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple notes:

  1. The changes should be at the suite level not at the per-feature test level:
    common.SetupBaseConfig(ctx, t, testInstallation, filepath.Join("manifests", "agent-gateway-base.yaml"))
  2. Please update the PR description to be correctly formatted based on the template (description, release note should be NONE for non-user changes, etc.)

@1Shubham7
Copy link
Contributor Author

got it @npolshakova ! since I just had changed one test, it would mess up other tests so that was a temp measure : )

also, what did you mean by non-user changes?

@npolshakova
Copy link
Contributor

The PR description needs to follow the PR template. See the contributing guide and design doc for changelog management for more info:

Use NONE for non-user facing changes.

…s to native go

Signed-off-by: shubham singh mahar <smahar@obmondo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/fix Categorizes issue or PR as related to a bug. release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants