Skip to content

Commit

Permalink
Updated and tested against Portal 7.4 U93
Browse files Browse the repository at this point in the history
  • Loading branch information
@kgolebiowski
kgolebiowski committed Sep 22, 2023
1 parent dea2b99 commit 8cdc6cb
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion gradle.properties
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ liferay.workspace.modules.dir=modules
liferay.workspace.themes.dir=themes
liferay.workspace.wars.dir=modules
microsoft.translator.subscription.key=
liferay.workspace.product=portal-7.4-ga52
liferay.workspace.product=portal-7.4-ga93
10 changes: 5 additions & 5 deletions ...settings/authentication/web/internal/portlet/action/CASPortalSettingsFormContributor.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ public class CASPortalSettingsFormContributor
implements PortalSettingsFormContributor {

@Override
public Optional<String> getDeleteMVCActionCommandNameOptional() {
return Optional.of("/portal_settings/cas_delete");
public String getDeleteMVCActionCommandName() {
return "/portal_settings/cas_delete";
}

@Override
Expand All @@ -46,8 +46,8 @@ public String getParameterNamespace() {
}

@Override
public Optional<String> getSaveMVCActionCommandNameOptional() {
return Optional.of("/portal_settings/cas");
public String getSaveMVCActionCommandName() {
return "/portal_settings/cas";
}

@Override
Expand Down Expand Up @@ -108,4 +108,4 @@ public void validateForm(
}
}

}
}

6 comments on commit 8cdc6cb

@Amal-AlAbbas
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can I use these files to integrate CAS in 7.4 g96?

@kgolebiowski
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can I use these files to integrate CAS in 7.4 g96?

Hi, please try, 96 is not far from 93 so maybe they haven't changed anything yet.

@Amal-AlAbbas
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I tried it and it worked, but I have a question, where I should add a link to my company?

@kgolebiowski
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amal

Hmm, I'm afraid I don't understand the question. The module works in exactly the same way as the old one in Liferay.

@Amal-AlAbbas
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am new in Liferay, so I don't have any idea about the way to use CAS, I think we will add a function and mapping attributes in the filter file, but I don't know how I need this necessity, because my company uses this way to login user, can u help me?

@kgolebiowski
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of this project is to adapt the legacy CAS module to Liferay 7.4, it's not about the CAS integration per se. I don't think it's a good place to provide general CAS support, maybe you could describe your problem and try to ask on Liferay Slack or the Forums?

Please sign in to comment.