Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict pulp version in template app #364

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

pvandyken
Copy link
Contributor

@pvandyken pvandyken commented Jan 12, 2024

The latest versions of pulp dropped a deprecated api snakemake dependended on. Newer versions of snakemake will address this, but older versions don't have an upper pin on pulp.

We cannot lower-pin the snakemake version, as we need older snakemakes to maintain support for python < 3.11.

This is not an ideal situation, as if we want the template app to work on all python versions supported by snakebids, and if we want to support all actively maintained pythons, we won't be able to drop this pin on pulp until python 3.10 is dropped, which won't be for a few years.

Probably the best is to wait until either 3.8 or 3.9 is EOL, then change the template app to require python >= 3.11 and snakemake >= 8.2. By that point, python 3.13 or 3.14 will be released, so people should have been able to get their default python version up to 3.11 or higher.

The latest versions of pulp dropped a deprecated api snakemake
dependended on. Newer versions of snakemake will address this, but older
versions don't have an upper pin on pulp.

We cannot lower-pin the snakemake version, as we need older snakemakes
to maintain support for python < 3.11.
@pvandyken pvandyken added the bug Something isn't working label Jan 12, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b38d6b2) 89.14% compared to head (24fc6f0) 78.97%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #364       +/-   ##
===========================================
- Coverage   89.14%   78.97%   -10.18%     
===========================================
  Files          30       30               
  Lines        1465     1465               
===========================================
- Hits         1306     1157      -149     
- Misses        159      308      +149     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kaitj kaitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR lgtm.

I'd consider adding an early deprecation message (towards the EOL of py3.9) if the plan is to drop support for py3.10 and move to supporting py3.11. Or can go the NumPy route - I think they always support the last supported version +1 (e.g. if Python is 3.8, they support 3.9+). Anyways, a discussion to be had later on.

@pvandyken
Copy link
Contributor Author

I'd consider adding an early deprecation message (towards the EOL of py3.9) if the plan is to drop support for py3.10 and move to supporting py3.11. Or can go the NumPy route - I think they always support the last supported version +1 (e.g. if Python is 3.8, they support 3.9+). Anyways, a discussion to be had later on.

My idea was not necessarily to fully drop 3.9 early, just in the template app. But that's a few years from now anyway, so no need to make a final decision now

@pvandyken pvandyken merged commit c3bba2f into khanlab:main Jan 15, 2024
34 checks passed
@pvandyken pvandyken deleted the fix/template/pulp-dependency branch January 15, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants