Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing sample data #22

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Removing sample data #22

merged 3 commits into from
Dec 12, 2024

Conversation

hwangswan
Copy link
Member

Removing sample data

1. Description

Now the test pipeline will use mock data from faker, not using sample data.

2. Changes

  • Creating data factory
  • Splitting requirements to a test requirements file.

@hwangswan
Updated test workflow
16034e5 
Removing sample data, using mock data via factory.

Splitting test requirements into a separate file.
@hwangswan
Modify the workflow to work only on main branch.
b25a348
@hwangswan
Restore requirements.
9050f4d
@trhgquan trhgquan self-requested a review December 12, 2024 09:07
trhgquan
trhgquan approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@trhgquan trhgquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trhgquan trhgquan merged commit 355e7f9 into khongsomeo:main Dec 12, 2024
1 check passed
@hwangswan hwangswan deleted the test branch December 12, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trhgquan trhgquan trhgquan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwangswan @trhgquan