Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring & added more testcases #23

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

hwangswan
Copy link
Member

@hwangswan hwangswan commented Dec 13, 2024

Code refactoring & added more testcases

1. Description

Code refactoring & added more testcases.

2. List of issues fixed:

None

Details:

  • Added type hinting.
  • Added 2 more testcases
  • StudentFactory now returning Vietnamese (Unicode) in vn language.

Mentioning @trhgquan for review

Update field name to fit with the original response.
@trhgquan trhgquan self-requested a review December 13, 2024 06:57
Copy link
Member

@trhgquan trhgquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes. Please have a look at comments.

tests/factory/student_factory.py Show resolved Hide resolved
@hwangswan hwangswan requested a review from trhgquan December 13, 2024 07:07
Copy link
Member

@trhgquan trhgquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trhgquan trhgquan merged commit 8f6b38e into khongsomeo:main Dec 13, 2024
1 check passed
@hwangswan hwangswan deleted the test branch December 13, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants