Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: mobile styles #134

Open
wants to merge 4 commits into
base: refactor
Choose a base branch
from
Open

refactor: mobile styles #134

wants to merge 4 commits into from

Conversation

kima-bastian
Copy link
Contributor

No description provided.

@kima-bastian
feat: transaction search
95a88a9 
- Moved getTxData to its own service for traversal use across the widget
- Moved footer buttons out of the transaction widget so users don't get confused for layout reasons
- Updated the reset button behaviour to reset the mode to payment or bridge wether exists a transactionOption set
- Changed the transaction Id type to number | string to avoid conflicts when using the simulator in future pocs (it returns a string in hexadecimal format)
@mayjer-kima
Copy link
Contributor

  • Having the "copy" button for the transaction ID is good
  • I'm not convinced about the 2nd part with the search when this can be done outside the widget by using "status mode"
    • There's already a lot of components on this view as well... looking very busy

image

Styling alignment:

  • Would look better if components aligned with the ones above
    • "Search" button was the same width as the "Next" button
    • "Transaction ID" input the same as "Target Address"
    • Label the same width as the other labels

@mayjer-kima
Copy link
Contributor

Transaction search:
Looks a lot better. Personal preference for the search button to be on the same row to reduce space.. though having it on a separate row would be consistent with the design so... 🤷
image

Responsive styling:

Does it do this for you too? Below 1000px width the window starts invading the container space of the widget:
image

at iPhone12 Pro size it's more severe:
image

@kima-bastian
Copy link
Contributor Author

Transaction search: Looks a lot better. Personal preference for the search button to be on the same row to reduce space.. though having it on a separate row would be consistent with the design so... 🤷 image

Responsive styling:

Does it do this for you too? Below 1000px width the window starts invading the container space of the widget: image

at iPhone12 Pro size it's more severe: image

mmm nope, I think it has to do with the container wrapping the app. We may want to add that to the documentation

@kima-bastian kima-bastian force-pushed the refactor branch 2 times, most recently from 12c416d to be0cee6 Compare February 6, 2025 13:32
@kima-bastian
Merge branch 'refactor' into mobile-styles
d6a8cde
@kima-bastian
refactor: transaction search screen
98b5674 
- removed transaction search for main
- added logic to determine valid transaction ids
- display the proper transaction metadata depending on the mode selected, a valid transaction id and the data returned by the status service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayjer-kima mayjer-kima Awaiting requested review from mayjer-kima

@HugoG-Crypto HugoG-Crypto Awaiting requested review from HugoG-Crypto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kima-bastian @mayjer-kima