fix(ui5-select): remove the cloning of the value state message (SAP#9654

) related to SAP#9347
kineticjs · Aug 7, 2024 · 1466076 · 1466076
1 parent dd8d77d
commit 1466076
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/packages/main/src/Select.ts b/packages/main/src/Select.ts
@@ -762,7 +762,7 @@ class Select extends UI5Element implements IFormInputElement {
 		if (this.shouldDisplayDefaultValueStateMessage) {
 			valueStateText = this.valueStateDefaultText;
 		} else {
-			valueStateText = this.valueStateMessageText.map(el => el.textContent).join(" ");
+			valueStateText = this.valueStateMessage.map(el => el.textContent).join(" ");
 		}
 
 		return `${this.valueStateTypeText} ${valueStateText}`;
@@ -854,12 +854,8 @@ class Select extends UI5Element implements IFormInputElement {
 		return getEffectiveAriaLabelText(this);
 	}
 
-	get valueStateMessageText() {
-		return this.getSlottedNodes("valueStateMessage").map(el => el.cloneNode(true));
-	}
-
 	get shouldDisplayDefaultValueStateMessage() {
-		return !this.valueStateMessageText.length && this.hasValueStateText;
+		return !this.valueStateMessage.length && this.hasValueStateText;
 	}
 
 	get hasValueStateText() {

diff --git a/packages/main/src/SelectPopover.hbs b/packages/main/src/SelectPopover.hbs
@@ -73,8 +73,6 @@
 	{{#if shouldDisplayDefaultValueStateMessage}}
 		{{valueStateText}}
 	{{else}}
-		{{#each valueStateMessageText}}
-			{{this}}
-		{{/each}}
+		<slot name="valueStateMessage"></slot>
 	{{/if}}
 {{/inline}}