fix: OverKeyboardView
rotation (fabric)
#918
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixed wrong dimensions when phone gets rotated.
💡 Motivation and Context
We need to update shadow node layout whenever screen dimensions changes, so in this PR I'm doing this. I use
onSizeChanged
method as a lifecycle method for updating layout. Technically I could useonLayout
, but it's highly undesirable to blockonLayout
method, so it's better to do it inonSizeChanged
.Fixes Android issue described in #915
📢 Changelog
Android
hostView
;ShadowNode
layout insidehostView
.🤔 How Has This Been Tested?
Tested manually on Medium Phone API 35.
📸 Screenshots (if appropriate):
okv-rotation.webm
📝 Checklist