Some minor fixes (#139)

* expose assessor for a submission

* fix crash when there are no exercises in a course

* fix crash in `GradingConfig#toString`

* apply spotless

src/main/java/edu/kit/kastel/sdq/artemis4j/client/ProgrammingExerciseDTO.java

@@ -37,5 +37,11 @@ public static List<ProgrammingExerciseDTO> fetchAll(ArtemisClient client, int co
      *
      * @param exercises
      */
-    private record ExerciseWrapperDTO(List<ProgrammingExerciseDTO> exercises) {}
+    private record ExerciseWrapperDTO(List<ProgrammingExerciseDTO> exercises) {
+        private ExerciseWrapperDTO {
+            if (exercises == null) {
+                exercises = List.of();
+            }
+        }
+    }
 }

src/main/java/edu/kit/kastel/sdq/artemis4j/client/TextExerciseDTO.java

@@ -42,5 +42,11 @@ public static List<TextExerciseDTO> fetchAll(ArtemisClient client, int courseId)
      * specific course with the exercises attached. We don't care about the course
      * here, so this wrapper class exists.
      */
-    private record ExerciseWrapperDTO(List<TextExerciseDTO> exercises) {}
+    private record ExerciseWrapperDTO(List<TextExerciseDTO> exercises) {
+        private ExerciseWrapperDTO {
+            if (exercises == null) {
+                exercises = List.of();
+            }
+        }
+    }
 }

src/main/java/edu/kit/kastel/sdq/artemis4j/grading/ProgrammingSubmission.java

@@ -94,6 +94,17 @@ public Optional<ResultDTO> getLatestResult() {
         }
     }
 
+    /**
+     * Get the assessor of this assessment.
+     * <p>
+     * This is the user who has locked the submission.
+     *
+     * @return the assessor or empty if the submission has not been assessed
+     */
+    public Optional<User> getAssessor() {
+        return this.getRelevantResult().map(ResultDTO::assessor).map(User::new);
+    }
+
     /**
      * Clones the submission, including the test repository, into the given path,
      * and checks out the submitted commit. This method uses the user's VCS access token, potentially creating a new one.

src/main/java/edu/kit/kastel/sdq/artemis4j/grading/penalty/MistakeType.java

@@ -92,6 +92,18 @@ public int hashCode() {
         return Objects.hashCode(id);
     }
 
+    @Override
+    public String toString() {
+        return "MistakeType{" + "id='"
+                + id + '\'' + ", rule="
+                + rule + ", ratingGroup="
+                + ratingGroup + ", message="
+                + message.getDefaultTranslationPattern() + ", buttonTexts="
+                + buttonTexts.getDefaultTranslationPattern() + ", reporting="
+                + reporting + ", autograderProblemTypes="
+                + autograderProblemTypes + '}';
+    }
+
     record MistakeTypeDTO(
             String shortName,
             String message,

src/main/java/edu/kit/kastel/sdq/artemis4j/grading/penalty/RatingGroup.java

@@ -80,8 +80,9 @@ public int hashCode() {
 
     @Override
     public String toString() {
-        return "RatingGroup[" + "id=" + id + ", " + "displayName=" + displayName + ", " + "minPenalty=" + minPenalty
-                + ", " + "getMaxPenalty=" + maxPenalty + ", " + "mistakeTypes=" + mistakeTypes + ']';
+        return "RatingGroup[" + "id=" + id + ", " + "displayName=" + displayName.getDefaultTranslationPattern() + ", "
+                + "minPenalty=" + minPenalty + ", " + "getMaxPenalty=" + maxPenalty + ", " + "mistakeTypes="
+                + mistakeTypes + ']';
     }
 
     record RatingGroupDTO(

src/main/java/edu/kit/kastel/sdq/artemis4j/i18n/FormatString.java

@@ -72,6 +72,14 @@ String translateTo(Locale locale, Object... args) {
         }
     }
 
+    /**
+     * The default pattern used by the format string.
+     * @return the default pattern
+     */
+    public String getDefaultTranslationPattern() {
+        return this.defaultTranslation.toPattern();
+    }
+
     @Override
     public String toString() {
         throw new IllegalStateException("Format & translate this string before using it.");