Added support of the 'location' parameter for Boto3 storage #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @kwrobot! Thank you! |
|
Hi @ivanchenkodmitry |
Hi @brianhelba |
|
hi @brianhelba ! Can you please check the pull request? this is a very minor thing it should not break enything Thank you. |
|
Hi @brianhelba ! Just want to follow up with this pull request. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django S3Boto3Storage provides ability to set the 'location' property which means prefix for all uploads.
In this case the path of the uploaded file will be stored in DB without the prefix and it will be added on each request to the file through the storage.
https://github.com/jschneier/django-storages/blob/master/storages/backends/s3boto3.py#L420
The current implementation of the django-s3-file-field does not support this parameter.
This commit should fix that.