Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static methods #567

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Fix static methods #567

merged 2 commits into from
Oct 22, 2020

Conversation

obfusk
Copy link
Contributor

@obfusk obfusk commented Oct 22, 2020

Properly fixes the issue found via #538.

This was already partially fixed between 1.2.1 and 1.3.0 because the new class hierarchy walk resulted in more JavaMultipleMethods, which already handled static methods correctly.

@obfusk obfusk mentioned this pull request Oct 22, 2020
Closed
@cmacdonald
Copy link
Contributor

The patch itself looks good. I was thinking about:
self.assertTrue(inst.getClass().isInstance(inst)).
To retain also the original intention of the test, could you also add:
self.assertTrue(ConstructorTest._class.isInstance(inst))

@obfusk obfusk force-pushed the fix-static-methods branch from 46e5e32 to 445839d Compare October 22, 2020 17:01
@obfusk
Copy link
Contributor Author

obfusk commented Oct 22, 2020

Thanks! I was looking for ._class to be able to do that :)

cmacdonald
cmacdonald approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@cmacdonald cmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve! Thanks!

tshirtman
tshirtman approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@tshirtman tshirtman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@tshirtman tshirtman merged commit 80815da into kivy:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshirtman tshirtman tshirtman approved these changes

@cmacdonald cmacdonald cmacdonald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@obfusk @cmacdonald @tshirtman