Handle case when rust macro node has no children of type identifier #670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prelude
Thank you for helping out vim-doge!
By contributing to vim-doge you agree to the following statements:
Why this PR?
To do an unhandled unwrap expression in the rust parser, vim-doge would crash if a macro within a function had no children with the type of identifier (from my understanding of the code). A minimal reproducible example of this would be with the
log
crate:Note that this doesn't even have to be within a Rust project as it will crash either way. I fixed this bug by just saying that the item doesn't panic if it has no children which are identifiers, which I believe was the intended behavior.
If you'd like me to remove the other changes that
rustfmt
automatically did when I saved the file, I can do that, but it did make it more consistent as there we're a few spots with 2-space indentation while the rest of the file was 4-space.Thanks so much!