Shore up behavior in high-CPU / high-RSS situations. #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen if the process is doing something CPU intensive which starves Sidekiq's heartbeat thready out for more than 60 seconds.
Relying on the sidekiq apis means getting sidekiq to stop once the memory limit is exceeded involves: - Spinning up a new thread - Make a redis call - Waiting for the sidekiq heartbeat thread to run When servers are under heavy resource load this is too much and can result in RSS continuing to grow and jobs continuing to process. So, immediately quiet the worker to stop processing ASAP while we let everything else settle out.
|
Hi @MrJoy and thank you for the contribution. The repo is not really maintained anymore. However, I am one of the former maintainer and could ensure a fork is updated. If you'd like that, I still have a few requests concerning your PR:
|
|
@BuonOmo I'll consult with my teammate who authored the changes and see what we can come up with! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.