Add FLAG_IMMUTABLE to PendingIntents to satisfy SDK 31+ requirements #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sredman
commented
Jan 21, 2023
| @@ -14,7 +14,7 @@ android { | |||
|
|
|||
| defaultConfig { | |||
| applicationId "com.klinker.android.send_message.sample" | |||
| minSdkVersion 14 | |||
| minSdkVersion 21 | |||
There was a problem hiding this comment.
Note that any app which consumes this change will have to bump the minSdkVersion to 21 (Android 5.0).
sredman
commented
Jan 21, 2023
| @@ -10,7 +10,7 @@ android { | |||
| compileSdkVersion 25 | |||
|
|
|||
| defaultConfig { | |||
| minSdkVersion 14 | |||
| minSdkVersion 21 | |||
There was a problem hiding this comment.
PendingIntent.FLAG_IMMUTABLE is added in SDK 21 (Android 5.0), so this bump is required.
kdesysadmin
pushed a commit
to KDE/kdeconnect-android
that referenced
this pull request
Jan 23, 2023
…upports SDK31 ## Summary Android apps which target SDK 31+ require specifying the mutability of any PENDING_INTENT. This is not supported in the upstream android-smsmms library: klinker41/android-smsmms#193 Until the above PR is merged, we need a solution. I have pulled the code into https://invent.kde.org/sredman/android-smsmms and published the package in the Maven repository in gitlab. BUG: 464392 ## Test Plan ### Before: Attempting to send an SMS or MMS message using kdeconnect-sms results in no message being sent, and an error being logged: > V/Sending message: Sending new SMS > E/Sending message: Exception > java.lang.IllegalArgumentException: org.kde.kdeconnect_tp: Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent. > Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles. > at android.app.PendingIntent.checkFlags(PendingIntent.java:382) > at android.app.PendingIntent.getBroadcastAsUser(PendingIntent.java:673) > at android.app.PendingIntent.getBroadcast(PendingIntent.java:660) > at com.klinker.android.send_message.Transaction.sendSmsMessage(Transaction.java:267) > at com.klinker.android.send_message.Transaction.sendNewMessage(Transaction.java:158) > at com.klinker.android.send_message.Transaction.sendNewMessage(Transaction.java:172) > at org.kde.kdeconnect.Plugins.SMSPlugin.SmsMmsUtils.sendMessage(SmsMmsUtils.java:188) > at org.kde.kdeconnect.Plugins.SMSPlugin.SMSPlugin.onPacketReceived(SMSPlugin.java:414) > at org.kde.kdeconnect.Device.onPacketReceived(Device.java:570) > <snipped for brevity> ### After: SMS and MMS sends normally.
|
@klinker41 any chance for a release including this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #187, post SDK 31, Android requires that any PendingIntent specify either FLAG_IMMUTABLE or FLAG_MUTABLE, with FLAG_MUTABLE being the default behavior prior to SDK 31.
This change moves relevant PendingIntents to FLAG_IMMUTABLE. This seems to be safe because the PendingIntents created by this library do not seem to require mutability.
FLAG_MUTABLE would require bumping all the way to SDK31; this is much more difficult because Android has hidden several methods of the ConnectivityManager class, such as startUsingNetworkFeature, for which there does not appear to be a drop-in replacement.
This has been tested in my use to send both SMS and MMS with attachment, where the app operates as not the default system messaging app. If the app were the default messaging app, FLAG_MUTABLE might be necessary (I do not know).