Revise prometheus export api #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going forward AppsCode operators will only add Prometheus exporter sidecar and create a stats service. It will not apply Promethus annotations on stats service or create ServiceMonitor. xref: #25 Signed-off-by: Tamal Saha <[email protected]>
tamalsaha
force-pushed
the
prom-api-review
branch
from
46bbd9a to
5c82991
Compare
tamalsaha
added a commit
to kubedb/apimachinery
that referenced
this pull request
Dec 23, 2019
- Deprecate Snapshot and DormantDatabse CRD - Add spec.paused field as a replacement for Pause/Resume feature - Update spec.monitor changed Prometheus exporter support. xref: kmodules/monitoring-agent-api#27 Signed-off-by: Tamal Saha <[email protected]>
tamalsaha
added a commit
to kubedb/apimachinery
that referenced
this pull request
Dec 23, 2019
- Deprecate Snapshot CRD. This is replaced by github.com/stashed - Deprecate DormantDatabse CRD - Add spec.paused field as a replacement for pause/resume feature of DormantDatabse CRD - Update spec.monitor changed Prometheus exporter support. xref: kmodules/monitoring-agent-api#27 Signed-off-by: Tamal Saha <[email protected]>
tamalsaha
added a commit
to kubedb/apimachinery
that referenced
this pull request
Dec 24, 2019
- Deprecate Snapshot CRD. This is replaced by github.com/stashed - Deprecate DormantDatabse CRD - Add spec.paused field as a replacement for pause/resume feature of DormantDatabse CRD - Update spec.monitor changed Prometheus exporter support. xref: kmodules/monitoring-agent-api#27 Signed-off-by: Tamal Saha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going forward AppsCode operators will only add Prometheus exporter sidecar and create a stats service. It will not apply Promethus annotations on stats service or create ServiceMonitor.
xref: #25
Signed-off-by: Tamal Saha [email protected]