Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backstage templates for Knative Functions #106

Merged
merged 19 commits into from
Oct 22, 2024

Conversation

aliok
Copy link
Member

@aliok aliok commented Oct 17, 2024

TODO:

  • GH automation to send a PR with function template changes No need, thanks to verify codegen GH action
  • Documentation to enable the templates (currently in this repo, later in Knative website)
  • Documentation to use the templates (currently in this repo, later in Knative website)
  • Prow to run code generation verification
  • Do not release in case of generation verification problem
  • Release procedure (for updating the func version): Func version bump step in Backstage release procedures knative/release#334

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 17, 2024
@knative-prow knative-prow bot requested review from Leo6Leo and pierDipi October 17, 2024 11:06
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 17, 2024
@aliok aliok force-pushed the 2024-09-26-template-work branch from e97601e to 8f885a5 Compare October 17, 2024 11:48
@aliok
Copy link
Member Author

aliok commented Oct 18, 2024

@pierDipi
Code generation verification is not done in Prow jobs in other repos, right?
Similarly, code generation verification is not done during a release in other repos?

@pierDipi
Copy link
Member

pierDipi commented Oct 18, 2024

Code generation verification is not done in Prow jobs in other repos, right?

Yes, that part is based on the existence of the hack/verify-codegen.sh file (which is not present in this repo), https://github.com/knative/hack?tab=readme-ov-file#using-the-presubmit-testssh-helper-script, point 2

Similarly, code generation verification is not done during a release in other repos?

no, it is done, this runs in the build tests job and those run before the release

@aliok aliok changed the title [WIP] Backstage templates for Knative Functions Backstage templates for Knative Functions Oct 21, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2024
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
Copy link

knative-prow bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aliok
Copy link
Member Author

aliok commented Oct 22, 2024

/override "Code Style / style / Golang / Lint"

Copy link

knative-prow bot commented Oct 22, 2024

@aliok: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Code Style / style / Golang / Lint

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • build-tests_backstage-plugins_main
  • e2e-tests_backstage-plugins_main
  • style / Golang / Lint
  • style / suggester / github_actions
  • tide
  • unit-tests_backstage-plugins_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Code Style / style / Golang / Lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aliok
Copy link
Member Author

aliok commented Oct 22, 2024

/override "style / Golang / Lint"

Copy link

knative-prow bot commented Oct 22, 2024

@aliok: Overrode contexts on behalf of aliok: style / Golang / Lint

In response to this:

/override "style / Golang / Lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 0d08724 into knative-extensions:main Oct 22, 2024
23 of 24 checks passed
@aliok aliok deleted the 2024-09-26-template-work branch October 22, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants