Fix: don't publish pod annotation update failure events.

[twoGiants]

Any kind of Operation cannot be fulfilled on ...: the object has been modified; please apply your changes to the latest version and try again errors are "normal" with knative controllers. To avoid the errors piling up in the Broker event section the exposure of those events was removed.

The warnings remain visible in the controller logs.

Fixes #4505

Proposed Changes

• 🐛 Remove FailedToUpdateDispatcherPodsAnnotation from broker.go and reciever_condition_set.go.
• 🐛 Remove failedToUpdateDispatcherPodsAnnotation from trigger.go and trigger_lifecycle.go.

Release Note

No warnings are listed in the Broker "Events" section when the Kafka controller is restarted and fails to update the dispatcher pod annotations

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: twoGiants
Once this PR has been reviewed and has the lgtm label, please assign aliok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow]

Welcome @twoGiants! It looks like this is your first PR to knative-extensions/eventing-kafka-broker 🎉

[knative-prow]

Hi @twoGiants. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[twoGiants]

/ok-to-test

[knative-prow]

@twoGiants: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Cali0707]

/ok-to-test

[Cali0707]

@twoGiants for the /ok-to-test to work you'll want to open a PR similar to knative/community#1364

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.00%. Comparing base (de6a2fa) to head (728a2cd).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4548      +/-   ##
==========================================
+ Coverage   29.96%   30.00%   +0.04%     
==========================================
  Files         290      290              
  Lines       19435    19407      -28     
==========================================
  Hits         5823     5823              
+ Misses      13159    13131      -28     
  Partials      453      453              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[matzew]

/retest

[twoGiants]

/test upgrade-tests