-
Notifications
You must be signed in to change notification settings - Fork 136
Fix: raise memory limits for Strimzi operator to avoid OOMKilled.
#4549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: raise memory limits for Strimzi operator to avoid OOMKilled.
#4549
Conversation
|
Hi @twoGiants. Thanks for your PR. I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This one probably does not need a release note? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file gets overridden, when we bump strimzi (for example like here #4484). In case you have a reproducer for it, maybe we could create a PR for the strimzi operator itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to reproduce the issue with the Strimzi quickstart. Will open the issue in their repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raised issue in strimzi/strimzi-kafka-operator#11964.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @twoGiants
| limits: | ||
| cpu: 1000m | ||
| memory: 384Mi | ||
| memory: 768Mi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about patch, in where we apply the file?
e.g. https://github.com/knative-extensions/eventing-kafka-broker/blob/main/test/kafka/kafka_setup.sh#L26-L27
(that already replaces the default namespace)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about
patch, in where we apply the file?
Yes, much better! Will patch there. Thank you 😸 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 😸
|
/ok-to-test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4549 +/- ##
=======================================
Coverage 29.96% 29.96%
=======================================
Files 290 290
Lines 19435 19435
=======================================
Hits 5823 5823
Misses 13159 13159
Partials 453 453 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Using Kind or Minikube locally the Strimzi operator gets regularly `OOMKilled`. Raising the memory limits to 768Mi fixes the issue permanently. Issue knative-extensions#4547 Signed-off-by: Stanislav Jakuschevskij <[email protected]>
d6db298 to
696b598
Compare
|
/test integration-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, twoGiants The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Using Kind or Minikube locally the Strimzi operator gets regularly
OOMKilled. Raising the memory limits to 768Mi fixes the issue permanently.Fixes #4547
Proposed Changes
768Mi.Release Note