Skip to content

Conversation

knative-automation
Copy link
Contributor

fix controller metrics crash -dprotaso

/cc knative-extensions/eventing-writers
/assign knative-extensions/eventing-writers

Produced by: knative-extensions/knobots/actions/update-deps

@knative-prow knative-prow bot requested a review from a team October 22, 2025 16:00
@knative-prow
Copy link

knative-prow bot commented Oct 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-automation
Once this PR has been reviewed and has the lgtm label, please assign skonto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.96%. Comparing base (9bbad15) to head (1dcf4b8).

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.19    #4563   +/-   ##
=============================================
  Coverage         29.96%   29.96%           
=============================================
  Files               290      290           
  Lines             19435    19435           
=============================================
  Hits               5823     5823           
  Misses            13159    13159           
  Partials            453      453           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bumping knative.dev/hack af735b2...50b120a:
  > 50b120a bump gotestfmt to newest version (# 449)
  > f2be520 [release-1.19] 🐛 Fix knative.dev/toolbox for older versions of Golang (# 444)
bumping knative.dev/eventing 931f60b...f53c251:
  > f53c251 [release-1.19] fix typo [skip-dot-release] (# 8743)
  > 5e02349 [release-1.19] Upgrade to latest dependencies (# 8720)
  > 49edf43 [release-1.19] Fix mt-broker-ingress auth to work with structured event too (# 8713)
bumping knative.dev/pkg 077dcf0...4ebd86b:
  > 4ebd86b upgrade to latest dependencies (# 3282)
  > 7da1174 upgrade to latest dependencies (# 3281)
  > 2be9d56 Lock before iterating map so that code does not panic on concurrent write (# 3279)
bumping knative.dev/reconciler-test 67ad192...b4a9751:
  > b4a9751 upgrade to latest dependencies (# 835)
  > 2f11b06 upgrade to latest dependencies (# 834)

Signed-off-by: Knative Automation <[email protected]>
@knative-automation knative-automation force-pushed the auto-updates/update-deps-release-1.19 branch from 33dd208 to 1dcf4b8 Compare October 22, 2025 16:40
@dprotaso
Copy link
Contributor

/retest

2 similar comments
@dprotaso
Copy link
Contributor

/retest

@dprotaso
Copy link
Contributor

/retest

@knative-prow
Copy link

knative-prow bot commented Oct 23, 2025

@knative-automation: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
upgrade-tests_eventing-kafka-broker_release-1.19 1dcf4b8 link true /test upgrade-tests
reconciler-tests-keda_eventing-kafka-broker_release-1.19 1dcf4b8 link true /test reconciler-tests-keda
channel-reconciler-tests-sasl-plain_eventing-kafka-broker_release-1.19 1dcf4b8 link true /test channel-reconciler-tests-sasl-plain
channel-reconciler-tests-sasl-ssl_eventing-kafka-broker_release-1.19 1dcf4b8 link true /test channel-reconciler-tests-sasl-ssl
channel-reconciler-tests-ssl_eventing-kafka-broker_release-1.19 1dcf4b8 link true /test channel-reconciler-tests-ssl
integration-tests_eventing-kafka-broker_release-1.19 1dcf4b8 link true /test integration-tests
reconciler-tests_eventing-kafka-broker_release-1.19 1dcf4b8 link true /test reconciler-tests
reconciler-tests-namespaced-broker_eventing-kafka-broker_release-1.19 1dcf4b8 link true /test reconciler-tests-namespaced-broker

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants