Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.17] fix linter config #831

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #820

@knative-prow knative-prow bot requested review from dprotaso and skonto March 28, 2025 01:02
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 28, 2025
@dprotaso
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2025
Copy link

knative-prow bot commented Mar 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2025
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.87%. Comparing base (523ecde) to head (7a200cb).
Report is 1 commits behind head on release-1.17.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.17     #831      +/-   ##
================================================
- Coverage         79.73%   74.87%   -4.87%     
================================================
  Files                17       17              
  Lines              1584     1584              
================================================
- Hits               1263     1186      -77     
- Misses              285      364      +79     
+ Partials             36       34       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Contributor

/override "codecov/project"

Copy link

knative-prow bot commented Mar 28, 2025

@dprotaso: Overrode contexts on behalf of dprotaso: codecov/project

In response to this:

/override "codecov/project"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit b6da539 into knative-extensions:release-1.17 Mar 28, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants