add tag label to HTTPRoute for traffic tag identification#931
add tag label to HTTPRoute for traffic tag identification#931kahirokunn wants to merge 1 commit intoknative-extensions:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kahirokunn The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #931 +/- ##
==========================================
- Coverage 76.38% 76.15% -0.23%
==========================================
Files 17 17
Lines 1266 1296 +30
==========================================
+ Hits 967 987 +20
- Misses 263 268 +5
- Partials 36 41 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // by comparing it with the ingress name. If the first segment of the host | ||
| // (before the first dot) ends with "-<ingressName>", the prefix is returned | ||
| // as the tag name. Returns empty string if no tag is found. | ||
| func TagOfHost(hosts []string, ingressName string) string { |
There was a problem hiding this comment.
This is fragile since the route tag to domain name can be customized.
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
11f4098 to
3e95149
Compare
Changes
When a Knative Service has traffic tags, tagged HTTPRoutes are generated but have no metadata indicating which tag they belong to. This makes it difficult for external tools to identify the traffic tag from HTTPRoute resources.
networking.internal.knative.dev/taglabel to tagged HTTPRoutes/kind enhancement
Release Note
Docs
Manual testing
Deployed a Knative Service with a traffic tag and confirmed the
networking.internal.knative.dev/taglabel is present on the tagged HTTPRoute: