feat: add RequestReply control plane #7411
knative-style.yaml
on: pull_request
style
/
changes
4s
style
/
...
/
Auto-format and Check
30s
style
/
...
/
Lint
4m 3s
style
/
...
/
Do Not Submit
8s
style
/
...
/
shell
0s
style
/
...
/
yaml
24s
style
/
...
/
github_actions
0s
Matrix: style / Golang / Boilerplate Check
Annotations
15 errors and 4 warnings
|
style / suggester / yaml
Process completed with exit code 255.
|
|
style / Golang / Boilerplate Check (go)
Process completed with exit code 1.
|
|
style / Golang / Boilerplate Check (go):
pkg/reconciler/requestreply/requestreply.go#L1
[Go headers] reported by reviewdog 🐶
missing boilerplate:
Raw Output:
pkg/reconciler/requestreply/requestreply.go:1: missing boilerplate:
/*
Copyright 2025 The Knative Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
|
|
style / Golang / Auto-format and Check
Process completed with exit code 1.
|
|
style / Golang / Auto-format and Check:
pkg/reconciler/testing/v1/pod.go#L0
Please run goimports.
diff --git a/pkg/reconciler/testing/v1/pod.go b/pkg/reconciler/testing/v1/pod.go
index 5bcdf47..5ae0437 100644
--- a/pkg/reconciler/testing/v1/pod.go
+++ b/pkg/reconciler/testing/v1/pod.go
@@ -90,4 +90,4 @@ func WithPodContainer(name, image string) PodOption {
p.Spec.Containers[0].Name = name
p.Spec.Containers[0].Image = image
}
-}
\ No newline at end of file
+}
|
|
style / Golang / Lint
Process completed with exit code 1.
|
|
style / Golang / Lint:
pkg/reconciler/testing/v1/pod.go#L93
[EOF Newline] reported by reviewdog 🐶
Missing newline
Raw Output:
pkg/reconciler/testing/v1/pod.go:93: Missing newline
|
|
style / Golang / Lint
issues found
|
|
style / Golang / Lint:
pkg/reconciler/requestreply/requestreply.go#L267
(*Reconciler).reconcileAddress - ctx is unused (unparam)
|
|
style / Golang / Lint:
pkg/reconciler/requestreply/requestreply.go#L246
(*Reconciler).reconcileBrokerAddressAnnotation - result 0 (error) is always nil (unparam)
|
|
style / Golang / Lint:
pkg/reconciler/requestreply/controller.go#L116
enqueueRequestRepliesForBroker - logger is unused (unparam)
|
|
style / Golang / Lint:
pkg/reconciler/requestreply/controller.go#L97
enqueueRequestRepliesForTrigger - logger is unused (unparam)
|
|
style / Golang / Lint:
pkg/reconciler/requestreply/requestreply.go#L189
ineffectual assignment to err (ineffassign)
|
|
style / Golang / Lint:
pkg/reconciler/requestreply/requestreply.go#L231
G115: integer overflow conversion int -> int32 (gosec)
|
|
style / Golang / Lint:
pkg/reconciler/requestreply/requestreply.go#L38
G101: Potential hardcoded credentials (gosec)
|
|
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
|
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
|
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|
|
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
|