Skip to content

feat: add RequestReply control plane #7426

feat: add RequestReply control plane

feat: add RequestReply control plane #7426

Triggered via pull request September 16, 2025 12:09
Status Failure
Total duration 4m 26s
Artifacts

knative-style.yaml

on: pull_request
style  /  changes
4s
style / changes
style  /  ...  /  Auto-format and Check
24s
style / Golang / Auto-format and Check
style  /  ...  /  Lint
4m 17s
style / Golang / Lint
style  /  ...  /  Do Not Submit
8s
style / Golang / Do Not Submit
style  /  ...  /  shell
0s
style / suggester / shell
style  /  ...  /  yaml
23s
style / suggester / yaml
style  /  ...  /  github_actions
0s
style / suggester / github_actions
Matrix: style / Golang / Boilerplate Check
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 4 warnings
style / suggester / yaml
Process completed with exit code 255.
style / Golang / Auto-format and Check
Process completed with exit code 1.
style / Golang / Auto-format and Check: pkg/reconciler/requestreply/requestreply.go#L0
Please run goimports. diff --git a/pkg/reconciler/requestreply/requestreply.go b/pkg/reconciler/requestreply/requestreply.go index 6b39153..e126220 100644 --- a/pkg/reconciler/requestreply/requestreply.go +++ b/pkg/reconciler/requestreply/requestreply.go @@ -203,8 +203,8 @@ func (r *Reconciler) reconcileTriggers(ctx context.Context, rr *v1alpha1.Request if equal, err := kmp.SafeEqual(t.Spec, desired.Spec, ignoreFields); !equal || err != nil { t.Spec = desired.Spec if _, err = r.eventingClient.EventingV1().Triggers(rr.Namespace).Update(ctx, t, metav1.UpdateOptions{}); err != nil { - triggerErrors = errors.Join(triggerErrors, fmt.Errorf("failed to update trigger: %w", err)) - } + triggerErrors = errors.Join(triggerErrors, fmt.Errorf("failed to update trigger: %w", err)) + } } else { // only check if it is ready if it was equal, otherwise it needs to re-reconcile if t.Status.IsReady() {
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum