Skip to content

Conversation

matzew
Copy link
Member

@matzew matzew commented Aug 27, 2025

Adding new sink type for AWS Event Bridge

Usage like:

---
apiVersion: sinks.knative.dev/v1alpha1
kind: IntegrationSink
metadata:
  name: eventbridge-sink
  namespace: knative-samples
spec:
  aws:
    eventbridge:
      arn: "arn:aws:events:my-region:...../my-event-bus"
      detailType: "Object created"
      eventSource: "curl.aws"
      region: "my-region"
    auth:
      secret:
        ref:
          name: "my-secret"
---
Adding new sink type for AWS Event Bridge

Docs

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2025
Copy link

knative-prow bot commented Aug 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2025
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 27, 2025
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 27, 2025
@knative-prow knative-prow bot requested review from creydr and pierDipi August 27, 2025 12:59
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2025
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.59%. Comparing base (427c91a) to head (899c737).

Files with missing lines Patch % Lines
...iler/integration/sink/resources/container_image.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8688      +/-   ##
==========================================
- Coverage   50.60%   50.59%   -0.02%     
==========================================
  Files         409      409              
  Lines       26707    26728      +21     
==========================================
+ Hits        13516    13522       +6     
- Misses      12338    12354      +16     
+ Partials      853      852       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matzew
Copy link
Member Author

matzew commented Sep 1, 2025

/test reconciler-tests

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2025
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2025
@matzew matzew changed the title WIP Event bridge AWS EventBridge Sink Oct 21, 2025
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2025
@matzew
Copy link
Member Author

matzew commented Oct 21, 2025

Copy link

knative-prow bot commented Oct 21, 2025

@matzew: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
upgrade-tests_eventing_main 899c737 link true /test upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants