Skip to content

Conversation

@creydr
Copy link
Member

@creydr creydr commented Sep 22, 2025

Cleaning up a left over from testing the auth-proxy

@creydr creydr requested review from Cali0707 and matzew September 22, 2025 07:07
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 22, 2025
@knative-prow knative-prow bot requested review from Leo6Leo and aliok September 22, 2025 07:08
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2025
@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.20%. Comparing base (903c74c) to head (64bdfa2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...iler/integration/sink/resources/container_image.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8735      +/-   ##
==========================================
- Coverage   50.22%   50.20%   -0.02%     
==========================================
  Files         409      409              
  Lines       26659    26659              
==========================================
- Hits        13390    13385       -5     
- Misses      12430    12431       +1     
- Partials      839      843       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2025
@knative-prow knative-prow bot merged commit ffe3a4b into knative:main Sep 22, 2025
35 of 36 checks passed
@knative-prow
Copy link

knative-prow bot commented Sep 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants