Skip to content

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Oct 2, 2025

I noticed a typo on the website.

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 2, 2025
@knative-prow knative-prow bot requested review from Cali0707 and pierDipi October 2, 2025 15:49
@dprotaso
Copy link
Member Author

dprotaso commented Oct 2, 2025

/cherry-pick release-1.19

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member Author

dprotaso commented Oct 2, 2025

/assign @Cali0707 @matzew @creydr

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.21%. Comparing base (bfd6957) to head (e1a3ed2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8742      +/-   ##
==========================================
- Coverage   50.23%   50.21%   -0.03%     
==========================================
  Files         409      409              
  Lines       26665    26665              
==========================================
- Hits        13396    13389       -7     
- Misses      12427    12434       +7     
  Partials      842      842              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 5828b49 into knative:main Oct 2, 2025
35 of 36 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #8743

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants