Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PNG optimization workflow #123

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Conversation

czyzby
Copy link
Contributor

@czyzby czyzby commented Dec 31, 2023


name: Pull Request
about: GitHub Actions setup
title: 'Add PNG optimization workflow'
labels: 'enhancement'
assignees: 'knyghtmare'


Describe your pull request does

This PR adds automatic workflow that optimizes and commits images to the master branch after every push.

Copy link
Owner

@knyghtmare knyghtmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the secret key from my end

@knyghtmare knyghtmare merged commit 31f48a0 into knyghtmare:master Dec 31, 2023
1 check passed
@czyzby
Copy link
Contributor Author

czyzby commented Dec 31, 2023

@knyghtmare Seems like it doesn't bypass the protected branch check after all. Other than adding the secret, are you sure the public key was added as a deploy key? Maybe you could also check the branch protection settings and see if you can enable direct commits with the deploy keys. If that ends up being a dead end, the only other way we could solve this is by opening PRs after each push, but that might increase the maintenance on your end a bit. Feel free to remove the workflow if ImgBot does that without all the hassle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants