Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace path.py with 2-line helper function #329

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

jnm
Copy link
Member

@jnm jnm commented Jan 21, 2025

To verify, follow the README to set up a virtual environment and run pytest. All tests should pass. The removed library was used only by unit tests.

Attention: if you receive AttributeError: 'Survey' object has no attribute 'update', this is caused by breaking changes in pyxform 3.0.0. Run pip install pyxform==2.2.0 and try again.

Internal discussion: https://chat.kobotoolbox.org/#narrow/stream/4-Kobo-Dev/topic/path.2C.20pathlib.2C.20path.2Epy

@coveralls
Copy link

Coverage Status

coverage: 86.669%. remained the same
when pulling 93f65d8 on remove-path.py-dependency
into 894d285 on main.

@jnm jnm merged commit 7b77ead into main Jan 22, 2025
3 checks passed
@jnm jnm deleted the remove-path.py-dependency branch January 22, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants