Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Extend Partial Perms #4733

Merged
merged 51 commits into from
Feb 27, 2024
Merged

Feature: Extend Partial Perms #4733

merged 51 commits into from
Feb 27, 2024

Conversation

magicznyleszek
Copy link
Member

@magicznyleszek magicznyleszek commented Nov 20, 2023 •
edited
Loading

Description

This is a feature PR - it gathers reviewed and tested code in a single PR. We do smaller branches that are based in feature/extend-partial-perms branch.

Development Notes

PRs related to this feature:

  • none

Includes code from:

@magicznyleszek magicznyleszek mentioned this pull request Nov 21, 2023
Merged
7 tasks
@magicznyleszek magicznyleszek mentioned this pull request Nov 24, 2023
Merged
7 tasks
@magicznyleszek magicznyleszek self-assigned this Nov 24, 2023
magicznyleszek and others added 17 commits November 24, 2023 15:01
@magicznyleszek
Merge branch 'kobo-select-style-fixes' into feature/extend-partial-perms
b956f3a
@magicznyleszek
Merge branch 'feature/extend-partial-perms' into feature-extend-parti…
d93172c 
…al-perms--add-partial-by-responses
@magicznyleszek
fix renderPartialByResponsesRow layout
58aa3cc
@magicznyleszek
add unlisteners to UserAssetPermsEditor
4ed1f10
@magicznyleszek
partial by responses permission saving code
936d41a
@magicznyleszek
add some tests and make displaying new partial perm possible
cae8cbb
@magicznyleszek
fix tests
427229e
@magicznyleszek
Merge branch 'beta' into feature/extend-partial-perms
0941496
@magicznyleszek
Merge branch 'feature/extend-partial-perms' into feature-extend-parti…
4a85ce1 
…al-perms--add-partial-by-responses
@bufke
Merge branch 'beta' of github.com:kobotoolbox/kpi into feature-extend…
b43cabc 
…-partial-perms--add-partial-by-responses
@bufke
Add AND/OR functionality to mongo helper permissions filters
a7fbe25
@bufke
Minor fix
3ceaacc
@bufke
Adjust asset permission assignment api to support AND/OR filters
bb05b00
@bufke
Update test_permissions for current implied permission strategy.
8650bcd
@bufke
Lint fix
caf7c7f
@bufke
Update docstring for add_implied_permission
96d4e8f
@magicznyleszek
rename userCanSubmission and fix tests for partial permissions
2ab5480
magicznyleszek and others added 22 commits January 9, 2024 13:20
@magicznyleszek
Merge branch 'feature-extend-partial-perms--add-partial-by-responses'…
ad929a4 
… of github.com:kobotoolbox/kpi into feature-extend-partial-perms--add-partial-by-responses
@magicznyleszek
Merge branch 'beta' into feature/extend-partial-perms
ad0bf74
@magicznyleszek
Merge branch 'feature/extend-partial-perms' into feature-extend-parti…
8e56ef9 
…al-perms--add-partial-by-responses

# Conflicts:
#	jsapp/js/components/permissions/sharingForm.scss
@magicznyleszek
Merge branch 'beta' into feature/extend-partial-perms
e5bde96
@magicznyleszek
Merge branch 'feature/extend-partial-perms' into feature-extend-parti…
a299234 
…al-perms--add-partial-by-responses
@magicznyleszek
Merge branch 'feature-extend-partial-perms--add-partial-by-responses'…
e863138 
… into mongo-helper-and-or
@magicznyleszek
adjust code to work with latest API architecture changes
774131d
@magicznyleszek
Merge branch 'feature-extend-partial-perms--add-partial-by-responses'…
b997dee 
… into mongo-helper-and-or
@noliveleger
Merge pull request #4781 from kobotoolbox/mongo-helper-and-or
8f68f30 
Add AND/OR functionality to mongo helper permissions filters
@magicznyleszek
fix tests, handle implied partial permissions properly
2a9a632
@magicznyleszek
Merge branch 'feature-extend-partial-perms--add-partial-by-responses'…
29b2413 
… of github.com:kobotoolbox/kpi into feature-extend-partial-perms--add-partial-by-responses
@magicznyleszek
add test for getFormData
1d1e732
@magicznyleszek
Merge branch 'rename-partial-permissions-variables' into feature/exte…
fcd2d62 
…nd-partial-perms
@magicznyleszek
Merge branch 'hardcode-permissions-labels' into feature/extend-partia…
1642c99 
…l-perms
@magicznyleszek
Merge branch 'feature/extend-partial-perms' into feature-extend-parti…
a70a7af 
…al-perms--add-partial-by-responses
@magicznyleszek
Merge branch 'beta' into feature/extend-partial-perms
9bb2323
@magicznyleszek
Merge branch 'feature/extend-partial-perms' into feature-extend-parti…
72f6dba 
…al-perms--add-partial-by-responses

# Conflicts:
#	jsapp/js/components/permissions/userAssetPermsEditor.component.tsx
#	jsapp/js/components/permissions/utils.ts
@magicznyleszek
rename function for more clarity
6eb7f3d
@magicznyleszek
remove unnecessary comment
fefe92b
@magicznyleszek
small ui improvements
24d16de
@magicznyleszek
allow empty value in "by responses" permission, add tests to cover th…
de60d66 
…at case
@magicznyleszek
Merge pull request #4824 from kobotoolbox/feature-extend-partial-perm…
5470756 
…s--add-partial-by-responses

[TASK-291] [TASK-292] Handle partial by responses permission in UI
@magicznyleszek magicznyleszek marked this pull request as ready for review February 10, 2024 01:03
@JacquelineMorrissette JacquelineMorrissette changed the base branch from beta to release/2.024.07 February 26, 2024 17:47
@magicznyleszek magicznyleszek merged commit 6952f77 into release/2.024.07 Feb 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@magicznyleszek magicznyleszek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magicznyleszek @bufke @noliveleger