Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK-1116] Automatic translations bugfix #5152

Conversation

magicznyleszek
Copy link
Member

@magicznyleszek magicznyleszek commented Oct 4, 2024

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Run ./python-format.sh to make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Fixes automatic translations not updating the UI upon start and upon receiving the translation response successfully.

Notes

This was introduced in #5059 and (of course) I introduced it. That PR was implementing better UX for translations, mimicking the previous PR that was doing the same thing for transcripts. I missed this one line, sorry 💔

Reproduction steps:

  1. Go to NLP/Processing view (through Project --> Data --> Table, in audio question response, "Open" button)
  2. Make some transcript (might be done in manual way), e.g. English text "Hello, World!"
  3. Go to "Translations" tab
  4. Make an automated translation:
  • Use "Begin" button
  • Select a language, e.g. French
  • Use "automatic" button
  1. Now you will see a bug:
  • Actual behavior: the UI becomes disabled, in Network tab you can notice the API call starts and finishes, the UI doesn't update
  • Expected behavior: the UI becomes disabled, in Network tab you can notice the API call starts, UI switches to a spinner with some info, API call finishes, the UI switches to the editor

Related issues

Fixes #5147

@magicznyleszek magicznyleszek marked this pull request as ready for review October 4, 2024 13:46
@jamesrkiger jamesrkiger merged commit f1a8ba2 into release/2.024.33 Oct 7, 2024
7 checks passed
@magicznyleszek magicznyleszek deleted the release-2.024.33--issue5147-automatic-translations-bugfix branch October 7, 2024 17:44
@magicznyleszek magicznyleszek changed the title Automatic translations bugfix [TASK-1116] Automatic translations bugfix Oct 16, 2024
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants