[TASK-1199] Fix geo-points not displaying in map #5206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
./python-format.sh
to make sure that your code lints and that you've followed our coding styleDescription
This PR fixes a bug where sometimes the geo-points are not properly plotted in form > data > map
Notes
Issue was in
map.es6
:buildMarkers
function did not have submissions data set when calledsetState
buildMarkers
was being called right after thesetState
, so the state wasn't yet ready when the function was executed.buildMarkers
(andbuildHeatMap
) were moved to the callback ofsetState
function, so they'll have the data to be processed.Testing