-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task-979] Remove submission counter and add organization name to header if MMO is enabled #5215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesrkiger
reviewed
Oct 31, 2024
jamesrkiger
reviewed
Oct 31, 2024
lgtm |
magicznyleszek
added a commit
that referenced
this pull request
Nov 19, 2024
Fixes bug introduced in #5215 - instead of removing `.main-header .main-header__counter` line, it was changed to `.main-header`.
Guitlle
pushed a commit
that referenced
this pull request
Nov 20, 2024
Fixes bug introduced in #5215 - instead of removing `.main-header .main-header__counter` line, it was changed to `.main-header`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
./python-format.sh
to make sure that your code lints and that you've followed our coding styleDescription
Adds a badge that displays the organization name of the MMO that the user is part of. Empty if not part of an MMO.
Removes the submission counter entirely.
Notes
When removing the submission counter I only found a
bem
related to themainHeader
component. I checked the code a few times to make sure some weird stuff wasn't happening that depended on this UI component and I found nothing.There is no character limit on the org name being displayed. We can possibly have extremely long names but it seems unlikely.
Testing
Enable MMO on user org and check the name to see if it's reflected in the badge.