Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task-979] Remove submission counter and add organization name to header if MMO is enabled #5215

Merged
merged 8 commits into from
Oct 31, 2024

Conversation

duvld
Copy link
Member

@duvld duvld commented Oct 30, 2024

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Run ./python-format.sh to make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes
  8. Create a testing plan for the reviewer and add it to the Testing section
  9. Add frontend or backend tag and any other appropriate tags to this pull request

Description

Adds a badge that displays the organization name of the MMO that the user is part of. Empty if not part of an MMO.

Removes the submission counter entirely.

Notes

When removing the submission counter I only found a bem related to the mainHeader component. I checked the code a few times to make sure some weird stuff wasn't happening that depended on this UI component and I found nothing.

There is no character limit on the org name being displayed. We can possibly have extremely long names but it seems unlikely.

Testing

Enable MMO on user org and check the name to see if it's reflected in the badge.

Copy link

@jamesrkiger
Copy link
Contributor

lgtm

@duvld duvld merged commit 9c1de70 into main Oct 31, 2024
6 of 7 checks passed
@duvld duvld deleted the task-979-Add-org-name-badge-to-app-header-nav branch October 31, 2024 19:30
@duvld duvld restored the task-979-Add-org-name-badge-to-app-header-nav branch November 8, 2024 16:44
magicznyleszek added a commit that referenced this pull request Nov 19, 2024
Fixes bug introduced in #5215 - instead of removing `.main-header
.main-header__counter` line, it was changed to `.main-header`.
Guitlle pushed a commit that referenced this pull request Nov 20, 2024
Fixes bug introduced in #5215 - instead of removing `.main-header
.main-header__counter` line, it was changed to `.main-header`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants