Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(CODEOWNERS): frontend tooling co-maintainer #5228

Merged
merged 8 commits into from
Nov 7, 2024
Merged

chore(CODEOWNERS): frontend tooling co-maintainer #5228

merged 8 commits into from
Nov 7, 2024

Conversation

p2edwards
Copy link
Contributor

💭 Notes

  • Frontend: Adding @p2edwards as co-maintainer for tooling/build systems
  • Backend
    • Treat Django-rendered HTML like frontend code, add self as co-owner for files I'm familiar with
    • Fix /test/ — this folder is frontend, replaced with /kpi/tests/, /hub/tests/ in backend section
  • Infrastructure: Add @p2edwards for npm-test.yml

Akuukis
Akuukis approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@Akuukis Akuukis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch about the test folders.

@p2edwards p2edwards merged commit 2bee143 into main Nov 7, 2024
7 checks passed
@p2edwards p2edwards deleted the phil/codeowners-frontend-tooling branch November 7, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicznyleszek magicznyleszek magicznyleszek approved these changes

@Akuukis Akuukis Akuukis approved these changes

@jnm jnm Awaiting requested review from jnm jnm is a code owner

@noliveleger noliveleger Awaiting requested review from noliveleger noliveleger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p2edwards @magicznyleszek @Akuukis