fix(openRosa): correct project lookup fallback between OpenRosa and KPI TASK-1645 #5564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noliveleger
changed the title
noliveleger
changed the title
noliveleger
changed the title
noliveleger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📣 Summary
Fixed a typo in the project lookup fallback when resolving links between OpenRosa and KPI.
📖 Description
A typo in the lookup fallback caused issues when resolving the link between KPI projects (Asset) and their corresponding OpenRosa projects (XForm). This fix corrects the fallback logic, ensuring that the correct KPI project is retrieved from an OpenRosa project when necessary.
👀 Preview steps
The preview steps are hard to reproduce since a project is now always deployed from KPI (not support by
v1anymore).See the new unit test to simulate preview steps.