refactor: image ipfs route #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Deploying with
|
| Latest commit: |
5fe13ac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cbe6cdc7.workers-ogi.pages.dev |
| Branch Preview URL: | https://refactor-image-ipfs-route.workers-ogi.pages.dev |
…de 200 and content type text/html
…2 - image test * test(ipfs.test.ts): change status code from 301 to 302 in ipfs - 302 - html test
vikiival
reviewed
Dec 5, 2023
image/src/routes/ipfs.ts
Outdated
Comment on lines
20
to
21
| // TODO: check response from cache | ||
| // ---------------------------------------- |
There was a problem hiding this comment.
Yes, I will investigate in a separate PR. on this one related to this issue: https://github.com/kodadot/workers/pull/162/files#diff-0f42d024452daf51c4b80efbd4f07ce3d5e123da6bc875c6740ff89d9d788903R125
…to cloudflare-images.ts refactor(ipfs.ts): replace inline fetch with getImageByPath function refactor(ipfs.ts): replace body type with IPFSResponseType feat(types.ts): add IPFSResponseType type refactor(ipfs.ts): remove redundant await in fetchIPFS call refactor(ipfs.ts): replace CFIApiResponse with IPFSResponseType
vikiival
approved these changes
Dec 5, 2023
|
Let's test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context