Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ipos): invalid cid #343

Merged
merged 2 commits into from
Oct 17, 2024
Merged

fix(ipos): invalid cid #343

merged 2 commits into from
Oct 17, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Oct 17, 2024 •
edited
Loading

Context

Tested

  • ✅ /pinJson
  • ✅ /pinFile one file , normal size
  • ✅ /pinFile one file , big size
  • ✅ /pinJson multiple files

uploading that same file

CleanShot 2024-10-17 at 09 21 12@2x

returns https://ipfs.filebase.io/ipfs/QmfZchkQpaS8wSF3FCEefwmmnEjRwjZSBs3JFnEJWDiDfP

and that matches

CleanShot 2024-10-17 at 09 20 45@2x

PR Type

  • Bugfix
  • Feature
  • Refactoring
  • Chore

@hassnian hassnian requested a review from vikiival October 17, 2024 04:21
@hassnian hassnian marked this pull request as ready for review October 17, 2024 04:25
@vikiival vikiival merged commit 9a9123c into kodadot:main Oct 17, 2024
3 checks passed
@vikiival vikiival mentioned this pull request Oct 17, 2024
Open
@hassnian hassnian deleted the fix-ipos-cid-mismatch branch October 18, 2024 04:41
This was referenced Oct 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hassnian @vikiival