Makes local user information optional. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changes PAM.authenticate to return a generic AuthenticatedUser. ** Uses UnixUser.exists instead of manually checking libc.passwd, then returns either a UnixUser or a generic AuthenticatedUser. ** Non-backwards compatible because of the method signature change on PAM.authenticate. * Changes UnixUser to be a subclass of the generic AuthenticatedUser. Fixes kohsuke#2
|
👍 Needed for LDAP/Radius/Whatever external authentication sources. |
|
@kohsuke any chance for this to get into libpam4j? |
|
My apologies for ignoring this for too long. It just went below my radar. I'd like to massage the change to be backward compatible. I think we can do it by using bridge method injector |
|
no worries, I know what it's like maintaining open source software. I think I can swing that change some time next week. Have a timeline for a new release in mind? |
| /* | ||
| * The MIT License | ||
| * | ||
| * Copyright (c) 2009, Sun Microsystems, Inc. |
There was a problem hiding this comment.
I presume this is incorrect, since this class was not made in 2009 by Sun though it looks like it's primarily pulled from UnixUser, which was.
Suggestions on what I should update it to while I'm changing things?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** Uses UnixUser.exists instead of manually checking libc.passwd, then returns either
a UnixUser or a generic AuthenticatedUser.
** Non-backwards compatible because of the method signature change on PAM.authenticate.
Fixes #2