Fix VS2022 build (OpenMP optional) and debugger working directory for examples/tests #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclearness
changed the title
Owner
|
Thanks a lot! |
takaya-murakami-RF
pushed a commit
to MapIV/small_gicp
that referenced
this pull request
Aug 21, 2025
* fix: update error value (koide3#97) * add ninja-build (koide3#99) * add ninja-build * add ninja-build * add ninja-build for coverage * improve batch_knn_search performance (koide3#101) * Fix typos and enable links (koide3#109) * chore: enable youtube link * chore: correct typos in comments * use ubuntu 24.04 runner to avoid packaging issue (koide3#111) * use ubuntu 24.04 runner to avoid packaging issue * ignore errors mismatch * change accessing order for column major (koide3#112) * sequential voxelmap accessor (koide3#113) * sequential voxelmap accessor * capital * fix typo (koide3#115) * Fix VS2022 build (OpenMP optional) and debugger working directory for examples/tests (koide3#119) * Pass compile on Windows * Set debugger working diretoriy as project root for examples and tests on Windows * [fix] remove omp schedule to avoid non-deterministic behavior --------- Co-authored-by: fateshelled <[email protected]> Co-authored-by: koide3 <[email protected]> Co-authored-by: atm <[email protected]> Co-authored-by: unclearness <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following fixes for Visual Studio 2022: